Feature/bca/spaces dnd #3502
Merged
Feature/bca/spaces dnd #3502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
force-pushed
the
feature/bca/spaces_dnd
branch
from
a3aa663 to
c322a46
Compare
BillCarsonFr
added
the
Z-NextRelease
Dominaezzz
reviewed
Jun 14, 2021
| return this | ||
| } | ||
|
|
||
| class TestSpaceComparator : Comparator<Pair<String, String?>> { |
Contributor
There was a problem hiding this comment.
val TestSpaceComparator = compareBy<Pair<String, String?>, String?>(nullsLast()) { it.second }
.thenBy { it.first }
Member
Author
There was a problem hiding this comment.
didn't know about the nullsLast, that's why I did the comparator
Member
There was a problem hiding this comment.
compareBy looks very powerful, but a bit hard to read and understand what it actually does at first sight :)
Member
Author
There was a problem hiding this comment.
we have 5 or 6 Comparator that could be implemented with thenBy
Contributor
There was a problem hiding this comment.
This might be a tiny bit easier to read. (Comes with a hint of overhead but it's up to you)
compareBy<Pair<String, String?>> {""}
.thenBy(nullsLast()) { it.second }
.thenBy { it.first }
bmarty
requested changes
Jun 16, 2021
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
LGTM, some small remark. Can you fix the issues reported by the CI please?
I will test on my device
matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/space/SpaceOrderUtils.kt
Show resolved
Hide resolved
matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/util/StringOrderUtils.kt
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/spaces/SpaceSummaryController.kt
Show resolved
Hide resolved
BillCarsonFr
force-pushed
the
feature/bca/spaces_dnd
branch
from
c322a46 to
be0797d
Compare
BillCarsonFr
force-pushed
the
feature/bca/spaces_dnd
branch
from
ff56726 to
944c964
Compare
+ klint fix
bmarty
approved these changes
Jun 18, 2021
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
Thanks for the update, I merge it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3501
Add support for top level space custom ordering